Plugin for custom evaluator for scaling metric evaluation #953
Conversation
…ration. 2. add sample custom evaluator for simple trend adjustor
| */ | ||
| Map<ScalingMetric, EvaluatedScalingMetric> evaluateVertexMetrics( | ||
| JobVertexID vertex, | ||
| Map<ScalingMetric, EvaluatedScalingMetric> evaluatedMetrics, |
There was a problem hiding this comment.
This parameter seems redundant because the context already contains the evaluated Metrics map.
There was a problem hiding this comment.
Since we are calling the custom evaluator before adding the current vertex’s evaluated metrics to scaling output. and we have to pass the vertex as an argument, passing evaluatedMetrics separately to the evaluation context sounded good to me!
Let me know if it makes more sense to have the vertex's evaluated metrics as part of the evaluation context itself, will make that update! Thanks!
| @@ -382,4 +385,19 @@ private static ConfigOptions.OptionBuilder autoScalerConfig(String key) { | |||
| "scaling.key-group.partitions.adjust.mode")) | |||
| .withDescription( | |||
| "How to adjust the parallelism of Source vertex or upstream shuffle is keyBy"); | |||
|
|
|||
| public static final ConfigOption<String> CUSTOM_EVALUATOR_NAME = | |||
There was a problem hiding this comment.
How about deriving the name from the CustomEvaluator interface? We can load all the names when we load the custom evaluator implementations.
There was a problem hiding this comment.
Thanks so much for your inputs! That Sounds perfect! Will make the update!
…he interface. 2. Updating javadoc’s for the added methods.
…tors for standalone autoscaler entrypoint.
pchoudhury22
changed the title
Plugin for custom evaluator for scaling metric evaluation as discussed part of FLIP-514: Custom Evaluator plugin for Flink Autoscaler
What is the purpose of the change
Add interface for custom evaluator as plugin for Autoscaler.
Verifying this change
New unit tests added to cover this
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: no